Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()

[Thomas Huth]

On 10/02/2021 12.15, Bin Meng wrote:
> Hi Philippe,
>
> On Wed, Feb 10, 2021 at 7:12 PM Philippe Mathieu-Daudé
> <philmd@redhat.com> wrote:
> > Hi Bin,
> >
> > On 2/10/21 11:23 AM, Bin Meng wrote:
> > > From: Bin Meng <bin.meng@windriver.com>
> > >
> > > Current QEMU HEAD nvme.c does not compile:
> > >
> > >    hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this 
> > > function [-Werror=maybe-uninitialized]
> > >           trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
> > >           ^
> > >    hw/block/nvme.c:3150:14: note: ‘result’ was declared here
> > >       uint32_t result;
> > >                ^
> >
> > Why isn't this catched by our CI? What is your host OS? Fedora 33?
>
> I am using GCC 5.4 on Ubuntu 16.04. Please see some initial analysis
> from Peter about why newer version GCC does not report it.

Please note that Ubuntu 16.04 is not a supported version by QEMU anymore, 
see https://qemu.readthedocs.io/en/latest/system/build-platforms.html and 
https://wiki.qemu.org/Supported_Build_Platforms for details.

 Thomas