Re: [PATCH v16 21/23] accel: introduce new accessor functions

[Philippe Mathieu-Daudé]

On 2/8/21 1:50 PM, Claudio Fontana wrote:
> On 2/5/21 9:14 PM, Richard Henderson wrote:
>> On 2/4/21 6:39 AM, Claudio Fontana wrote:
>>> @@ -6725,10 +6722,8 @@ static void x86_cpu_initfn(Object *obj)
>>>          x86_cpu_load_model(cpu, xcc->model);
>>>      }
>>>  
>>> -    /* if required, do the accelerator-specific cpu initialization */
>>> -    if (cc->accel_cpu) {
>>> -        cc->accel_cpu->cpu_instance_init(CPU(obj));
>>> -    }
>>> +    /* if required, do accelerator-specific cpu initializations */
>>> +    accel_cpu_instance_init(CPU(obj));
>>>  }
>>
>> Why is this only done for x86?
>>
>>
>> r~
>>
> 
> It makes sense to include the other architectures.
> 
> As the next step I would like to apply this to ARM, but to me it makes sense 
> to first complete Philippe's series,
> which reshuffles things so that TCG-only / KVM-only builds are both possible 
> and error-free:
> 
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg777627.html

TBH this series is very unlikely to be merged before yours,
so go ahead... (eventually you can cherry-pick what you need
from it).