Re: [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate

[Rebecca Cran]

On 2/3/21 10:17 AM, Richard Henderson wrote:
> On 2/2/21 6:58 PM, Rebecca Cran wrote:
> >           if (!arm_singlestep_active(env)) {
> > -            env->uncached_cpsr &= ~PSTATE_SS;
> > +            env->pstate &= ~PSTATE_SS;
> > +        } else {
> > +            env->pstate |= PSTATE_SS;
> >           }
>
> Where did this addition come from?

I thought this was needed given your comment:

"This is missing the restore of PSTATE_SS for when singlestep *is* active."

--
Rebecca Cran