Re: [PATCH] iotests/297: pylint: ignore too many statements

[John Snow]

On 1/29/21 4:50 AM, Kevin Wolf wrote:
> Am 28.01.2021 um 21:08 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > 28.01.2021 23:04, Vladimir Sementsov-Ogievskiy wrote:
> > > Ignore two complains, which now lead to 297 failure on testenv.py and
> > > testrunner.py.
> > >
> > > Fixes: 2e5a2f57db481f18fcf70be2a36b1417370b8476
> > > Fixes: d74c754c924ca34e90b7c96ce2f5609d82c0e628
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > ---
> >
> > Forget to note:
> >
> > I don't add exclusions to pylintrc intentionally, as I think these
> > warnings are reasonable, and it's good that vim ALE show them.. Still,
> > adding them to pylintrc works too if you prefer.
>
> I would have disabled the warning completely because I don't think
> length in lines is a good measure for code quality. But if we think that
> these warnings are in fact reasonable, then we should fix them and not
> just disable them partially.
>
> It's the same reason why we have -Werror enabled. If you leave warnings
> around without any intention to fix them, the useful warnings will drown
> in the masses of intentionally ignored ones.
>
> Kevin

It's at least a sniff test. There are extremely valid reasons for many 
of the "warnings" to be suppressed, but usually you should have to 
consciously justify it, I think.

Vladimir put the suppression in pylintrc under the "Temporary" section 
for v2, which I think is appropriate, so I gave it my R-B.

--js