Re: [PATCH RFC 1/1] hw: Replace anti-social QOM type names

[Paolo Bonzini]

On 29/01/21 09:15, Markus Armbruster wrote:
> diff --git a/hw/block/fdc.c b/hw/block/fdc.c
> index 7fc547c62d..0dd158bf73 100644
> --- a/hw/block/fdc.c
> +++ b/hw/block/fdc.c
> @@ -2547,7 +2547,7 @@ void sun4m_fdctrl_init(qemu_irq irq, hwaddr io_base,
>      DeviceState *dev;
>      FDCtrlSysBus *sys;
>  
> -    dev = qdev_new("SUNW,fdtwo");
> +    dev = qdev_new("SUNW-fdtwo");
>      sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal);
>      sys = SYSBUS_FDC(dev);
>      sysbus_connect_irq(SYS_BUS_DEVICE(sys), 0, irq);


Missing:

        fdc_name = object_get_typename(OBJECT(fdc_dev));
        drive_suffix = !strcmp(fdc_name, "SUNW,fdtwo") ? "" : i ? "B" : 
"A";
        warn_report("warning: property %s.drive%s is deprecated",
                    fdc_name, drive_suffix);
        error_printf("Use -device floppy,unit=%d,drive=... instead.\n", i);