[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 10/23] linux-user: Fix guest_addr_valid vs reserved_va
From: |
Richard Henderson |
Subject: |
[PATCH v4 10/23] linux-user: Fix guest_addr_valid vs reserved_va |
Date: |
Thu, 28 Jan 2021 12:41:28 -1000 |
We must always use GUEST_ADDR_MAX, because even 32-bit hosts can
use -R <reserved_va> to restrict the memory address of the guest.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
include/exec/cpu_ldst.h | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index 4e6ef3d542..e62f4fba00 100644
--- a/include/exec/cpu_ldst.h
+++ b/include/exec/cpu_ldst.h
@@ -72,11 +72,10 @@ typedef uint64_t abi_ptr;
/* All direct uses of g2h and h2g need to go away for usermode softmmu. */
#define g2h(x) ((void *)((uintptr_t)(abi_ptr)(x) + guest_base))
-#if HOST_LONG_BITS <= TARGET_VIRT_ADDR_SPACE_BITS
-#define guest_addr_valid(x) (1)
-#else
-#define guest_addr_valid(x) ((x) <= GUEST_ADDR_MAX)
-#endif
+static inline bool guest_addr_valid(abi_ulong x)
+{
+ return x <= GUEST_ADDR_MAX;
+}
static inline bool guest_range_valid(abi_ulong start, abi_ulong len)
{
--
2.25.1
- [PATCH v4 00/23] target-arm: Implement ARMv8.5-MemTag, user mode, Richard Henderson, 2021/01/28
- [PATCH v4 01/23] tcg: Introduce target-specific page data for user-only, Richard Henderson, 2021/01/28
- [PATCH v4 04/23] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/01/28
- [PATCH v4 02/23] linux-user: Introduce PAGE_ANON, Richard Henderson, 2021/01/28
- [PATCH v4 07/23] linux-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/01/28
- [PATCH v4 03/23] exec: Use uintptr_t for guest_base, Richard Henderson, 2021/01/28
- [PATCH v4 05/23] exec: Improve types for guest_addr_valid, Richard Henderson, 2021/01/28
- [PATCH v4 10/23] linux-user: Fix guest_addr_valid vs reserved_va,
Richard Henderson <=
- [PATCH v4 09/23] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/01/28
- [PATCH v4 06/23] linux-user: Check for overflow in access_ok, Richard Henderson, 2021/01/28
- [PATCH v4 11/23] exec: Add support for TARGET_TAGGED_ADDRESSES, Richard Henderson, 2021/01/28
- [PATCH v4 08/23] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/01/28
- [PATCH v4 13/23] target/arm: Improve gen_top_byte_ignore, Richard Henderson, 2021/01/28
- [PATCH v4 15/23] linux-user/aarch64: Implement PR_MTE_TCF and PR_MTE_TAG, Richard Henderson, 2021/01/28
- [PATCH v4 12/23] linux-user/aarch64: Implement PR_TAGGED_ADDR_ENABLE, Richard Henderson, 2021/01/28
- [PATCH v4 14/23] target/arm: Use the proper TBI settings for linux-user, Richard Henderson, 2021/01/28
- [PATCH v4 17/23] target/arm: Split out syndrome.h from internals.h, Richard Henderson, 2021/01/28
- [PATCH v4 16/23] linux-user/aarch64: Implement PROT_MTE, Richard Henderson, 2021/01/28