Re: [PATCH 1/1] docs: fix mistake in dirty bitmap feature description

[Vladimir Sementsov-Ogievskiy]

28.01.2021 20:13, Denis V. Lunev wrote:
> Original specification says that l1 table size if 64 * l1_size, which
> is obviously wrong. The size of the l1 entry is 64 _bits_, not bytes.
> Thus 64 is to be replaces with 8 as specification says about bytes.
>
> There is also minor tweak, field name is renamed from l1 to l1_table,
> which matches with the later text.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

> ---
>   docs/interop/parallels.txt | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/interop/parallels.txt b/docs/interop/parallels.txt
> index e9271eba5d..f15bf35bd1 100644
> --- a/docs/interop/parallels.txt
> +++ b/docs/interop/parallels.txt
> @@ -208,7 +208,7 @@ of its data area are:
>     28 - 31:    l1_size
>                 The number of entries in the L1 table of the bitmap.
>   
> -  variable:   l1 (64 * l1_size bytes)
> +  variable:   l1_table (8 * l1_size bytes)
>                 L1 offset table (in bytes)

I don't remember why this "(in bytes)" is here.. What in bytes? L1 table size? 
But the described field is not L1 table size, but L1 table itself.. It's not in bytes, 
it's just L1 table :)

So, I'd also drop "(in bytes)" while being here. Or the whole line "L1 offset table 
(in bytes)" altogether.

>   
>   A dirty bitmap is stored using a one-level structure for the mapping to host


--
Best regards,
Vladimir