Re: [PATCH v2 00/25] Convert CMSDK timer, watchdog, dualtimer to Clock framework

[Philippe Mathieu-Daudé]

On 1/28/21 12:41 PM, Peter Maydell wrote:
> This patchset converts the CMSDK timer, watchdog and dualtimer devices
> to use the Clock framework instead of an integer property specifying
> a frequency in Hz. The series is quito a lot of patches but they
> should be mostly small and I hope easy to review.
> 
> The motivation here is the upcoming Arm SSE-300 model: this has a
> new kind of timer device, which I wanted to write in the modern style
> with a Clock input. That meant the ARMSSE container object needed
> to know about Clocks, so converting the existing devices it used
> to Clocks seemed like a good first step.
> 
> The series as a whole is a migration compat break for the machines
> involved: mps2-an385, mps2-an386, mps2-an500, mps2-an511, mps2-an505,
> mps2-an521, musca-a, musca-b1, lm3s811evb, lm3s6965evb.
> 
> v1->v2 changes (all very minor so I have left r-by tags in place):
>  * in test cases, remove set-but-never-used QTestState* variables; gcc
>    warns about these (I did my development with clang, which does not...)
>    (patches 3, 4, 5)
>  * in test cases, consistently phrase clock_step() arguments as calculations
>    based on tick counts and the ns-per-tick value rather than just the final
>    numbers (eg '500 * 40 + 1' instead of '20001') (patches 3, 5)
>  * correct the forward-step amount when looking for periodic timer reload
>    of the dualtimer (patch 5)
>  * actually wire up the ARMSSE MAINCLK callback function (patch 22)
> 
> The only patch still unreviewed is 5 ("tests: Add a simple test of the
> CMSDK APB dual timer").
> 
> thanks
> -- PMM
> 
> Peter Maydell (25):
>   ptimer: Add new ptimer_set_period_from_clock() function
>   clock: Add new clock_has_source() function
>   tests: Add a simple test of the CMSDK APB timer
>   tests: Add a simple test of the CMSDK APB watchdog
>   tests: Add a simple test of the CMSDK APB dual timer
>   hw/timer/cmsdk-apb-timer: Rename CMSDKAPBTIMER struct to CMSDKAPBTimer
>   hw/timer/cmsdk-apb-timer: Add Clock input
>   hw/timer/cmsdk-apb-dualtimer: Add Clock input
>   hw/watchdog/cmsdk-apb-watchdog: Add Clock input
>   hw/arm/armsse: Rename "MAINCLK" property to "MAINCLK_FRQ"
>   hw/arm/armsse: Wire up clocks
>   hw/arm/mps2: Inline CMSDK_APB_TIMER creation
>   hw/arm/mps2: Create and connect SYSCLK Clock
>   hw/arm/mps2-tz: Create and connect ARMSSE Clocks
>   hw/arm/musca: Create and connect ARMSSE Clocks
>   hw/arm/stellaris: Convert SSYS to QOM device
>   hw/arm/stellaris: Create Clock input for watchdog
>   hw/timer/cmsdk-apb-timer: Convert to use Clock input
>   hw/timer/cmsdk-apb-dualtimer: Convert to use Clock input
>   hw/watchdog/cmsdk-apb-watchdog: Convert to use Clock input
>   tests/qtest/cmsdk-apb-watchdog-test: Test clock changes
>   hw/arm/armsse: Use Clock to set system_clock_scale
>   arm: Don't set freq properties on CMSDK timer, dualtimer, watchdog,
>     ARMSSE
>   arm: Remove frq properties on CMSDK timer, dualtimer, watchdog, ARMSSE
>   hw/arm/stellaris: Remove board-creation reset of STELLARIS_SYS

Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>