Re: [PATCH v4] Add support for pvpanic pci device

[Peter Maydell]

On Wed, 20 Jan 2021 at 11:21, Mihai Carabas <mihai.carabas@oracle.com> wrote:
>
> This patchset adds support for pvpanic pci device.
>
> v3:
> - patch 1: made pvpanic isa device available only for PC, compile pvpanic-test
>   only when isa device is present
> - patch 2: fixed device id to 0x0011, used OBJECT_DECLARE_TYPE,
>   PVPANIC_PCI_DEVICE, added VMSTATE_PCI_DEVICE, removed INTERFACE_PCIE_DEVICE
> - patch 3: fixed documentation
> - patch 4: add a qtest for pvpanic-pci

This fails make check (x86-64 host, clang, sanitizer build):

Running test qtest-ppc64/pvpanic-pci-test
../../tests/qtest/libqos/pci.c:256:17: runtime error: member access
within null pointer of type 'QPCIDevice' (aka 'struct QPCIDevice')
../../tests/qtest/libqos/pci.c:256:17: runtime error: load of null
pointer of type 'QPCIBus *' (aka 'struct QPCIBus *')
UndefinedBehaviorSanitizer:DEADLYSIGNAL
==24237==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address
0x000000000000 (pc 0x5560e21f4d32 bp 0x5560e35d0c00 sp 0x7ffd75fd4740
T24237)
==24237==The signal is caused by a READ memory access.
==24237==Hint: address points to the zero page.
    #0 0x5560e21f4d31 in qpci_config_readw
/home/petmay01/linaro/qemu-from-laptop/qemu/build/clang/../../tests/qtest/libqos/pci.c:256:17
    #1 0x5560e21f5201 in qpci_device_enable
/home/petmay01/linaro/qemu-from-laptop/qemu/build/clang/../../tests/qtest/libqos/pci.c:107:11
    #2 0x5560e21eaa79 in test_panic
/home/petmay01/linaro/qemu-from-laptop/qemu/build/clang/../../tests/qtest/pvpanic-pci-test.c:64:5
    #3 0x7f4fd6d6cf29  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72f29)
    #4 0x7f4fd6d6ce5a  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e5a)
    #5 0x7f4fd6d6ce5a  (/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x72e5a)
    #6 0x7f4fd6d6d101 in g_test_run_suite
(/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73101)
    #7 0x7f4fd6d6d120 in g_test_run
(/usr/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x73120)
    #8 0x5560e21eaa15 in main
/home/petmay01/linaro/qemu-from-laptop/qemu/build/clang/../../tests/qtest/pvpanic-pci-test.c:91:11
    #9 0x7f4fd5d49bf6 in __libc_start_main
/build/glibc-S7xCS9/glibc-2.27/csu/../csu/libc-start.c:310
    #10 0x5560e21ca559 in _start
(/home/petmay01/linaro/qemu-from-laptop/qemu/build/clang/tests/qtest/pvpanic-pci-test+0x7d559)

UndefinedBehaviorSanitizer can not provide additional info.
==24237==ABORTING

thanks
-- PMM