[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Fix zone write validation

From: Klaus Jensen
Subject: Re: [PATCH 0/3] Fix zone write validation
Date: Tue, 26 Jan 2021 09:21:58 +0100

On Jan 26 14:02, Dmitry Fomichev wrote:
> These patches solve a few problems that exist in zoned Write
> ans Zone Append validation code.
> Dmitry Fomichev (3):
>   hw/block/nvme: Check for zone boundary during append
>   hw/block/nvme: Check zone state before checking boundaries
>   hw/block/nvme: Add trace events for zone boundary violations
>  hw/block/nvme.c       | 35 ++++++++++++++++++++---------------
>  hw/block/trace-events |  3 +++
>  2 files changed, 23 insertions(+), 15 deletions(-)

I don't think there are any obvious benefits to this series over my fix
and since you didn't identify any functional issues with it, I'm
thinking we go with that.

My fix additionally removes setting ALBA in the CQE for regular writes
and bundles the endianness fix by changing the related logic in

I have a couple of series in queue that also includes zoned writes and
there is no reason they have to indirectly deal with append. It's just
cleaner to move this special case closer to where it's used.

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]