[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 06/25] util: Add CRC16 (CCITT) calculation routines |
|
Date: |
Sun, 24 Jan 2021 11:41:25 -1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 1/24/21 10:24 AM, Philippe Mathieu-Daudé wrote:
> On 1/24/21 9:07 PM, Richard Henderson wrote:
>> Doesn't this get put in libutil, where it is only pulled from the archive
>> when
>> needed? Also, libutil is built once, not per-target.
>
> Hmm I just sent a pull request with this change squashed in.
> Should I cancel it?
I guess not.
> My view is we don't install libqemuutil.a anywhere, so why overload
> building unused objects when some configuration don't need it?
My view is that util/meson.build should not be overly complicated with
conditionals.
If we were building objects per-target, that would be one thing. If we were
doing --whole-archive, and including unused code in the executables, that would
be another thing. But otherwise...
r~
[PATCH v2 10/25] hw/sd: ssi-sd: Support multiple block read, Bin Meng, 2021/01/23
[PATCH v2 12/25] hw/sd: sd: Remove duplicated codes in single/multiple block read/write, Bin Meng, 2021/01/23
[PATCH v2 11/25] hw/sd: ssi-sd: Use macros for the dummy value and tokens in the transfer, Bin Meng, 2021/01/23
[PATCH v2 08/25] hw/sd: ssi-sd: Add a state representing Nac, Bin Meng, 2021/01/23
[PATCH v2 18/25] hw/sd: ssi-sd: Bump up version ids of VMStateDescription, Bin Meng, 2021/01/23