Re: [PATCH 1/2] meson: Explicit TCG backend used

[Thomas Huth]

On 22/01/2021 10.22, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>   meson.build | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 8535a83fb70..0a645e54662 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -2419,8 +2419,12 @@
>   endif
>   summary_info += {'TCG support':       config_all.has_key('CONFIG_TCG')}
>   if config_all.has_key('CONFIG_TCG')
> +  if config_host.has_key('CONFIG_TCG_INTERPRETER')
> +    summary_info += {'TCG backend':   'TCG interpreter (experimental)'}

maybe say "experimental and slow" in the parentheses?

> +  else
> +    summary_info += {'TCG backend':   'native (@0@)'.format(cpu)}
> +  endif
>     summary_info += {'TCG debug enabled': 
> config_host.has_key('CONFIG_DEBUG_TCG')}
> -  summary_info += {'TCG interpreter':   
> config_host.has_key('CONFIG_TCG_INTERPRETER')}
>   endif
>   summary_info += {'target list':       ' '.join(target_dirs)}
>   if have_system

Reviewed-by: Thomas Huth <thuth@redhat.com>