[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 01/13] qemu-nbd: Fix a memleak in qemu_nbd_client_list()
From: |
Eric Blake |
Subject: |
[PULL 01/13] qemu-nbd: Fix a memleak in qemu_nbd_client_list() |
Date: |
Wed, 20 Jan 2021 20:36:45 -0600 |
From: Alex Chen <alex.chen@huawei.com>
When the qio_channel_socket_connect_sync() fails
we should goto 'out' label to free the 'sioc' instead of return.
Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Alex Chen <alex.chen@huawei.com>
Message-Id: <20201130123651.17543-1-alex.chen@huawei.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
---
qemu-nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index a7075c5419d7..47587a709e6b 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -181,7 +181,7 @@ static int qemu_nbd_client_list(SocketAddress *saddr,
QCryptoTLSCreds *tls,
sioc = qio_channel_socket_new();
if (qio_channel_socket_connect_sync(sioc, saddr, &err) < 0) {
error_report_err(err);
- return EXIT_FAILURE;
+ goto out;
}
rc = nbd_receive_export_list(QIO_CHANNEL(sioc), tls, hostname, &list,
&err);
--
2.30.0
- [PULL 00/13] NBD patches through 2021-01-20, Eric Blake, 2021/01/20
- [PULL 01/13] qemu-nbd: Fix a memleak in qemu_nbd_client_list(),
Eric Blake <=
- [PULL 02/13] qemu-nbd: Fix a memleak in nbd_client_thread(), Eric Blake, 2021/01/20
- [PULL 04/13] nbd/server: Quiesce coroutines on context switch, Eric Blake, 2021/01/20
- [PULL 05/13] iotests/277: use dot slash for nbd-fault-injector.py running, Eric Blake, 2021/01/20
- [PULL 03/13] block: Honor blk_set_aio_context() context requirements, Eric Blake, 2021/01/20
- [PULL 07/13] iotests: fix some whitespaces in test output files, Eric Blake, 2021/01/20
- [PULL 08/13] iotests: make tests executable, Eric Blake, 2021/01/20
- [PULL 10/13] iotests: define group in each iotest, Eric Blake, 2021/01/20
- [PULL 11/13] iotests/264: fix style, Eric Blake, 2021/01/20
- [PULL 13/13] iotests.py: qemu_io(): reuse qemu_tool_pipe_and_status(), Eric Blake, 2021/01/20