[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 09/11] migration: introduce a delete_snapshot wrapper
From: |
Eric Blake |
Subject: |
Re: [PATCH v9 09/11] migration: introduce a delete_snapshot wrapper |
Date: |
Wed, 20 Jan 2021 11:32:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/20/21 4:44 AM, Daniel P. Berrangé wrote:
> Make snapshot deletion consistent with the snapshot save
> and load commands by using a wrapper around the blockdev
> layer. The main difference is that we get upfront validation
> of the passed in device list (if any).
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> include/migration/snapshot.h | 13 +++++++++++++
> migration/savevm.c | 14 ++++++++++++++
> monitor/hmp-cmds.c | 2 +-
> 3 files changed, 28 insertions(+), 1 deletion(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- Re: [PATCH v9 02/11] migration: Make save_snapshot() return bool, not 0/-1, (continued)
- [PATCH v9 03/11] migration: stop returning errno from load_snapshot(), Daniel P . Berrangé, 2021/01/20
- [PATCH v9 04/11] block: add ability to specify list of blockdevs during snapshot, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 05/11] block: allow specifying name of block device for vmstate storage, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 07/11] migration: control whether snapshots are ovewritten, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 06/11] block: rename and alter bdrv_all_find_snapshot semantics, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 08/11] migration: wire up support for snapshot device selection, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 09/11] migration: introduce a delete_snapshot wrapper, Daniel P . Berrangé, 2021/01/20
- Re: [PATCH v9 09/11] migration: introduce a delete_snapshot wrapper,
Eric Blake <=
- [PATCH v9 10/11] iotests: add support for capturing and matching QMP events, Daniel P . Berrangé, 2021/01/20
- [PATCH v9 11/11] migration: introduce snapshot-{save, load, delete} QMP commands, Daniel P . Berrangé, 2021/01/20