qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 05/30] Makefile: wrap ctags in quiet-command calls


From: Philippe Mathieu-Daudé
Subject: Re: [PULL 05/30] Makefile: wrap ctags in quiet-command calls
Date: Mon, 18 Jan 2021 19:36:22 +0100

Hi Alex,

On Fri, Jan 15, 2021 at 2:08 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> For prettier output.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Reviewed-by: Willian Rampazzo <willianr@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Message-Id: <20210114165730.31607-6-alex.bennee@linaro.org>
>
> diff --git a/Makefile b/Makefile
> index 0c509a7704..bbab640b31 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -250,8 +250,13 @@ find-src-path = find "$(SRC_PATH)/" -path 
> "$(SRC_PATH)/meson" -prune -o \( -name
>
>  .PHONY: ctags
>  ctags:
> -       rm -f "$(SRC_PATH)/"tags
> -       $(find-src-path) -exec ctags -f "$(SRC_PATH)/"tags --append {} +
> +       $(call quiet-command,                   \
> +               rm -f "$(SRC_PATH)/"tags,       \
> +               "CTAGS", "Remove old tags")
> +       $(call quiet-command, \
> +               $(find-src-path) -exec ctags            \
> +               -f "$(SRC_PATH)/"tags --append {} +,    \
> +               "CTAGS", "Re-index $(SRC_PATH)")
>
>  .PHONY: gtags
>  gtags:
> --
> 2.20.1
>

Build now fails if ctags is not installed:

$ if test -n "$MAKE_CHECK_ARGS"; then make -j"$JOBS" $MAKE_CHECK_ARGS ; fi
CTAGS Remove old tags
CTAGS Re-index /builds/philmd/qemu
find: 'ctags': No such file or directory
find: 'ctags': No such file or directory
find: 'ctags': No such file or directory
make: *** [Makefile:254: ctags] Error 1
make: *** Waiting for unfinished jobs....




reply via email to

[Prev in Thread] Current Thread [Next in Thread]