Re: [PATCH] hw/block/nvme: add zoned I/O commands to nvme_io_opc_str()

[Klaus Jensen]

On Jan 15 22:48, Minwoo Im wrote:
> Currently, Zoned I/O commands are parsed as unknown:
>   pci_nvme_io_cmd cid 768 nsid 1 sqid 4 opc 0x79 opname 'NVME_NVM_CMD_UNKNOWN'
> 
> Parse zoned I/O commands along with other I/O commands to print.
> 
> Signed-off-by: Minwoo Im <minwoo.im.dev@gmail.com>
> ---
>  hw/block/nvme.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/hw/block/nvme.h b/hw/block/nvme.h
> index b7fbcca39d9f..0c1cb6fd2549 100644
> --- a/hw/block/nvme.h
> +++ b/hw/block/nvme.h
> @@ -66,6 +66,9 @@ static inline const char *nvme_io_opc_str(uint8_t opc)
>      case NVME_CMD_READ:             return "NVME_NVM_CMD_READ";
>      case NVME_CMD_WRITE_ZEROES:     return "NVME_NVM_CMD_WRITE_ZEROES";
>      case NVME_CMD_DSM:              return "NVME_NVM_CMD_DSM";
> +    case NVME_CMD_ZONE_MGMT_SEND:   return "NVME_NVM_CMD_ZONE_MGMT_SEND";
> +    case NVME_CMD_ZONE_MGMT_RECV:   return "NVME_NVM_CMD_ZONE_MGMT_RECV";
> +    case NVME_CMD_ZONE_APPEND:      return "NVME_NVM_CMD_ZONE_APPEND";
>      default:                        return "NVME_NVM_CMD_UNKNOWN";
>      }
>  }
> -- 
> 2.17.1
> 

I have this in a series under review. Compare is also missing ;)

"[PATCH 5/6] hw/block/nvme: add missing string representations for commands"

signature.asc
Description: PGP signature