[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h

From: Markus Armbruster
Subject: Re: [PATCH] monitor/qmp-cmds.c: Don't include ui/vnc.h
Date: Fri, 15 Jan 2021 14:28:44 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)

Peter Maydell <peter.maydell@linaro.org> writes:

> The qmp-cmds.c file currently includes ui/vnc.h, which (being located
> in the ui/ directory rather than include) is really supposed to be
> for use only by the ui subsystem.  In fact the function prototypes we
> need (vnc_display_password(), etc) are all declared in
> include/ui/console.h, so we can switch to including that instead.
> (ui/vnc.h includes include/ui/console.h, so this change strictly
> reduces the quantity of headers qmp-cmds.c pulls in.)
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Almost missed this one.  Queued, thanks!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]