[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support st
From: |
David Gibson |
Subject: |
Re: [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static |
Date: |
Fri, 15 Jan 2021 11:43:21 +1100 |
On Thu, Jan 14, 2021 at 03:06:23PM -0300, Daniel Henrique Barboza wrote:
> The function is called only inside spapr_hcall.c.
>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Nice catch - that's a hangover from an earlier version where it was
called elswhere. Applied to ppc-for-6.0.
> ---
> hw/ppc/spapr_hcall.c | 1 +
> include/hw/ppc/spapr.h | 5 -----
> 2 files changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c
> index e5dfc1ba7a..7b5cd3553c 100644
> --- a/hw/ppc/spapr_hcall.c
> +++ b/hw/ppc/spapr_hcall.c
> @@ -1632,6 +1632,7 @@ static uint32_t cas_check_pvr(PowerPCCPU *cpu, uint32_t
> max_compat,
> return best_compat;
> }
>
> +static
> target_ulong do_client_architecture_support(PowerPCCPU *cpu,
> SpaprMachineState *spapr,
> target_ulong vec,
> diff --git a/include/hw/ppc/spapr.h b/include/hw/ppc/spapr.h
> index 4d37c2a93b..a2d1fb21c6 100644
> --- a/include/hw/ppc/spapr.h
> +++ b/include/hw/ppc/spapr.h
> @@ -583,11 +583,6 @@ void spapr_register_hypercall(target_ulong opcode,
> spapr_hcall_fn fn);
> target_ulong spapr_hypercall(PowerPCCPU *cpu, target_ulong opcode,
> target_ulong *args);
>
> -target_ulong do_client_architecture_support(PowerPCCPU *cpu,
> - SpaprMachineState *spapr,
> - target_ulong addr,
> - target_ulong fdt_bufsize);
> -
> /* Virtual Processor Area structure constants */
> #define VPA_MIN_SIZE 640
> #define VPA_SIZE_OFFSET 0x4
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v1 0/7] pseries: avoid unplug the last online CPU core + assorted fixes, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 1/7] spapr.h: fix trailing whitespace in phb_placement, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static, Daniel Henrique Barboza, 2021/01/14
- Re: [PATCH v1 2/7] spapr_hcall.c: make do_client_architecture_support static,
David Gibson <=
- [PATCH v1 5/7] spapr_cpu_core.c: use g_auto* in spapr_create_vcpu(), Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 3/7] spapr_rtas.c: fix identation in rtas_ibm_nmi_interlock() string, Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 6/7] spapr.c: introduce spapr_core_unplug_possible(), Daniel Henrique Barboza, 2021/01/14
- [PATCH v1 7/7] spapr.c: consider CPU core online state before allowing unplug, Daniel Henrique Barboza, 2021/01/14