[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert()
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] utils/fifo8: change fatal errors from abort() to assert() |
|
Date: |
Thu, 14 Jan 2021 12:06:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/14/21 11:15 AM, Claudio Fontana wrote:
> On 1/14/21 10:58 AM, Mark Cave-Ayland wrote:
>> On 14/01/2021 09:07, Claudio Fontana wrote:
>>
>>> On 1/14/21 9:33 AM, Mark Cave-Ayland wrote:
>>>> Developer errors are better represented with assert() rather than abort().
>>>
>>> ... "also, make the tests more strict"
>>>
>>> I'd add this since the checks have been changed sometimes in the patch to
>>> be more strict.
>>>
>>> Reviewed-by: Claudio Fontana <cfontana@suse.de>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>