[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.p
From: |
Eric Blake |
Subject: |
Re: [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running |
Date: |
Wed, 13 Jan 2021 16:37:37 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/9/21 6:26 AM, Vladimir Sementsov-Ogievskiy wrote:
> If you run './check 277', check includes common.config which adjusts
> $PATH to include '.' first, and therefore finds nbd-fault-injector.py
> on PATH. But if you run './277' directly, there is nothing to adjust
> PATH, and if '.' is not already on your PATH by other means, the test
> fails because the executable is not found. Adjust how we invoke the
> helper executable to avoid needing a PATH search in the first place.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> tests/qemu-iotests/277 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
As this one touches NBD, I'm happy to queue it in my next NBD pull
request if the entire series takes longer to collect enough reviews.
>
> diff --git a/tests/qemu-iotests/277 b/tests/qemu-iotests/277
> index d34f87021f..a39ce2d873 100755
> --- a/tests/qemu-iotests/277
> +++ b/tests/qemu-iotests/277
> @@ -42,7 +42,7 @@ def make_conf_file(event):
> def start_server_NBD(event):
> make_conf_file(event)
>
> - srv = subprocess.Popen(['nbd-fault-injector.py', '--classic-negotiation',
> + srv = subprocess.Popen(['./nbd-fault-injector.py',
> '--classic-negotiation',
> nbd_sock, conf_file], stdout=subprocess.PIPE,
> stderr=subprocess.STDOUT, universal_newlines=True)
> line = srv.stdout.readline()
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
- [PATCH v6 00/11] Rework iotests/check, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running, Vladimir Sementsov-Ogievskiy, 2021/01/09
- Re: [PATCH v6 01/11] iotests/277: use dot slash for nbd-fault-injector.py running,
Eric Blake <=
- [PATCH v6 09/11] iotests: add testrunner.py, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 02/11] iotests/303: use dot slash for qcow2.py running, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 10/11] iotests: rewrite check into python, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 03/11] iotests: fix some whitespaces in test output files, Vladimir Sementsov-Ogievskiy, 2021/01/09
- [PATCH v6 04/11] iotests: make tests executable, Vladimir Sementsov-Ogievskiy, 2021/01/09