[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/12] qapi: static typing conversion, pt1.5
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 00/12] qapi: static typing conversion, pt1.5 |
Date: |
Wed, 13 Jan 2021 17:23:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Hi, this patchset enables strict optional checking in mypy for
> everything we have typed so far.
>
> In general, this patchset seeks to eliminate Optional[T] in favor of T
> wherever possible. Optional types used for object properties,
> function/method parameters and return values where we expect, in most
> cases, to be non-None is troublesome as it requires peppering the code
> with assertions about state. If and whenever possible, prefer using
> non-Optional types.
>
> Ironing out these issues allows us to be even stricter with our type
> checking, which improves consistency in subclass interface types and
> should make review a little nicer.
>
> This series is based on (but does not require) the 'qapi: sphinx-autodoc
> for qapi module' series.
Just two issues left that aren't entirely trivial: 1. mission creep
[PATCH 6+7], 2. integrating my "[PATCH 00/11] Drop support for QAPIGen
without a file name".
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH v2 00/12] qapi: static typing conversion, pt1.5,
Markus Armbruster <=