Re: [PATCH v1 9/9] gitlab: move docs and tools build across from Travis

[Daniel P . Berrangé]

On Wed, Jan 13, 2021 at 03:46:17PM +0000, Peter Maydell wrote:
> On Wed, 13 Jan 2021 at 15:40, Daniel P. Berrangé <berrange@redhat.com> wrote:
> >
> > On Wed, Jan 13, 2021 at 03:14:08PM +0000, Alex Bennée wrote:
> > > While we are at it we might as well check the tag generation. For
> > > bonus points we run GNU globals htags into the public pages directory
> > > for publishing with the auto generated pages.
> 
> > > +build-tools-and-docs-debian:
> > > +  <<: *native_build_job_definition
> > > +  variables:
> > > +    IMAGE: debian-amd64
> > > +    MAKE_CHECK_ARGS: ctags gtags TAGS cscope
> > > +    CONFIGURE_ARGS: --enable-docs --enable-tools
> > > +  artifacts:
> > > +    expire_in: 2 days
> > > +    paths:
> > > +      - build
> >
> > Do we actually need this job at all ?
> >
> > Assuming the depenedancies are in the dockerfile, then all the
> > build jobs will be testing docs and tools already, as meson will
> > auto enable it.
> 
> What I would like to see is a set of "just build the docs"
> CI jobs which test all our supported Sphinx versions
> (eg 1.6, 2.0, 2.4, 3.0, 3.2), since we've found that Sphinx
> is not great about consistency of accepted syntax from
> version to version. (Somebody sent a patch for this ages
> ago, but it was for a Travis CI job IIRC, which we're trying
> to move away from.)

We only care about the Sphinx versions that exist in the OS distros that
we're targetting as build platforms. So as long as we have build jobs for
all the distros we have dockerfiles for, then we're covering all the
sphinx versions that matter.  IOW, I think our gitlab jobs are already
covering a good variety of sphinx versions. There are possibly gaps because
our dockerfiles have a horribly inconsistent set of RPMs listed. This
inconsistency is addressed in this patch series of mine to autogenerate
the dockerfiles:

 https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg00189.html

which will ensure all our dockerfiles have the deps needed to satisfy
all features in QEMU.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|