[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 07/10] Disable auto-coverge before entering COLO mode.
From: |
leirao |
Subject: |
[PATCH 07/10] Disable auto-coverge before entering COLO mode. |
Date: |
Wed, 13 Jan 2021 10:46:32 +0800 |
From: "Rao, Lei" <lei.rao@intel.com>
If we don't disable the feature of auto-converge for live migration
before entering COLO mode, it will continue to run with COLO running,
and eventually the system will hang due to the CPU throttle reaching
DEFAULT_MIGRATE_MAX_CPU_THROTTLE.
Signed-off-by: Lei Rao <lei.rao@intel.com>
---
migration/migration.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
diff --git a/migration/migration.c b/migration/migration.c
index 31417ce..6ab37e5 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1673,6 +1673,20 @@ void migrate_set_block_enabled(bool value, Error **errp)
qapi_free_MigrationCapabilityStatusList(cap);
}
+static void colo_auto_converge_enabled(bool value, Error **errp)
+{
+ MigrationCapabilityStatusList *cap = NULL;
+
+ if (migrate_colo_enabled() && migrate_auto_converge()) {
+ QAPI_LIST_PREPEND(cap,
+ migrate_cap_add(MIGRATION_CAPABILITY_AUTO_CONVERGE,
+ value));
+ qmp_migrate_set_capabilities(cap, errp);
+ qapi_free_MigrationCapabilityStatusList(cap);
+ }
+ cpu_throttle_stop();
+}
+
static void migrate_set_block_incremental(MigrationState *s, bool value)
{
s->parameters.block_incremental = value;
@@ -3401,7 +3415,7 @@ static MigIterateState
migration_iteration_run(MigrationState *s)
static void migration_iteration_finish(MigrationState *s)
{
/* If we enabled cpu throttling for auto-converge, turn it off. */
- cpu_throttle_stop();
+ colo_auto_converge_enabled(false, &error_abort);
qemu_mutex_lock_iothread();
switch (s->state) {
--
1.8.3.1
- RE: [PATCH 02/10] Fix the qemu crash when guest shutdown during checkpoint, (continued)
- [PATCH 03/10] Optimize the function of filter_send, leirao, 2021/01/12
- [PATCH 04/10] Remove migrate_set_block_enabled in checkpoint, leirao, 2021/01/12
- [PATCH 05/10] Optimize the function of packet_new, leirao, 2021/01/12
- [PATCH 06/10] Add the function of colo_compare_cleanup, leirao, 2021/01/12
- [PATCH 08/10] Reduce the PVM stop time during Checkpoint, leirao, 2021/01/12
- [PATCH 07/10] Disable auto-coverge before entering COLO mode.,
leirao <=
- [PATCH 09/10] Add the function of colo_bitmap_clear_diry, leirao, 2021/01/12
- [PATCH 10/10] Fixed calculation error of pkt->header_size in fill_pkt_tcp_info(), leirao, 2021/01/12