[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 31/35] Hexagon (tests/tcg/hexagon) TCG tests
From: |
Taylor Simpson |
Subject: |
RE: [PATCH v6 31/35] Hexagon (tests/tcg/hexagon) TCG tests |
Date: |
Tue, 12 Jan 2021 17:06:44 +0000 |
> -----Original Message-----
> From: Alex Bennée <alex.bennee@linaro.org>
> Sent: Tuesday, January 12, 2021 6:04 AM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: ale@rev.ng; Brian Cain <bcain@quicinc.com>;
> richard.henderson@linaro.org; laurent@vivier.eu; philmd@redhat.com;
> qemu-devel@nongnu.org
> Subject: Re: [PATCH v6 31/35] Hexagon (tests/tcg/hexagon) TCG tests
>
> Taylor Simpson <tsimpson@quicinc.com> writes:
>
> > Modify tests/tcg/configure.sh
> > Add reference files to tests/tcg/hexagon
> > Add Hexagon-specific tests
> >
> > Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> > ---
> > tests/tcg/hexagon/atomics.c | 122 ++++++
> > tests/tcg/hexagon/clrtnew.c | 56 +++
> > tests/tcg/hexagon/dual_stores.c | 60 +++
> > tests/tcg/hexagon/fpstuff.c | 370 ++++++++++++++++++
> > tests/tcg/hexagon/mem_noshuf.c | 328 ++++++++++++++++
> > tests/tcg/hexagon/misc.c | 360 +++++++++++++++++
> > tests/tcg/hexagon/preg_alias.c | 106 +++++
> > tests/tcg/hexagon/pthread_cancel.c | 43 +++
> > tests/tcg/configure.sh | 4 +-
> > tests/tcg/hexagon/Makefile.target | 48 +++
>
> Could you split this patch up please. I would say:
>
> 1: configure.sh, Makefilefile.target with multiarch tests (and float
> ref files)
> 2. atomics/loadstore/mem tests
> 3. additional fp tests
Sure.
> BTW is there enough support for a bare metal system emulation test? You
> would need a minimal boot.S and a library function for outputting
> characters to some device and an exit which can set the return code.
This is in progress but not ready for submission. Once this series is merged,
the plan is to incrementally add the remaining user space instructions,
including HVX then add the system mode support.
> > +static void *func(void *arg)
> > +{
> > + sleep(3);
> > + return 0;
> > +}
> > +
> > +int main()
> > +{
> > + int err = 0;
> > + pthread_t thread;
> > + void *res;
> > +
> > + pthread_create(&thread, 0, func, NULL);
> > + pthread_cancel(thread);
> > + pthread_join(thread, &res);
> > + if (res != PTHREAD_CANCELED) {
> > + err++;
> > + }
> > +
> > + puts(err == 0 ? "PASS" : "FAIL");
> > + return err == 0 ? 0 : -1;
> > +}
>
> This seems like it could be a multiarch test unless the othread cancel
> semantics for Hexagon/Linux are very different.
Yes, it could be a multiarch test. I'll create a standalone patch (not part of
this series) to add this to tests/tcg/multiarch/testthread.c.
Thanks for the feedback,
Taylor
- [PATCH v6 23/35] Hexagon (target/hexagon) opcode data structures, (continued)
- [PATCH v6 23/35] Hexagon (target/hexagon) opcode data structures, Taylor Simpson, 2021/01/07
- [PATCH v6 24/35] Hexagon (target/hexagon) macros, Taylor Simpson, 2021/01/07
- [PATCH v6 27/35] Hexagon (target/hexagon) TCG for instructions with multiple definitions, Taylor Simpson, 2021/01/07
- [PATCH v6 28/35] Hexagon (target/hexagon) TCG for floating point instructions, Taylor Simpson, 2021/01/07
- [PATCH v6 25/35] Hexagon (target/hexagon) instruction classes, Taylor Simpson, 2021/01/07
- [PATCH v6 32/35] Hexagon build infrastructure, Taylor Simpson, 2021/01/07
- [PATCH v6 29/35] Hexagon (target/hexagon) translation, Taylor Simpson, 2021/01/07
- [PATCH v6 33/35] Add Dockerfile for hexagon, Taylor Simpson, 2021/01/07
- [PATCH v6 31/35] Hexagon (tests/tcg/hexagon) TCG tests, Taylor Simpson, 2021/01/07
- [PATCH v6 34/35] Auto-import Docker support files, Taylor Simpson, 2021/01/07
[PATCH v6 35/35] Add newline when generating Dockerfile, Taylor Simpson, 2021/01/07
Re: [PATCH v6 00/35] Hexagon patch series, no-reply, 2021/01/08
Re: [PATCH v6 00/35] Hexagon patch series, Alex Bennée, 2021/01/12