[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA b
From: |
Jiaxun Yang |
Subject: |
Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge |
Date: |
Mon, 11 Jan 2021 09:38:22 +0800 |
User-agent: |
Cyrus-JMAP/3.5.0-alpha0-45-g4839256-fm-20210104.001-g48392560 |
On Mon, Jan 11, 2021, at 3:25 AM, BALATON Zoltan wrote:
> On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote:
> > +PCI experts
> >
> > On 1/10/21 1:43 AM, BALATON Zoltan wrote:
> >> On Sun, 10 Jan 2021, Philippe Mathieu-Daudé wrote:
[...]
> > I'm not a PCI expert but my understanding is PCI device functions are
> > restricted to the PCI bus address space. The host bridge may map this
> > space within the host.
> >
> > QEMU might be using get_system_memory() because for some host bridge
> > the mapping is not implemented so it was easier this way?
>
> Maybe, also one less indirection which if not really needed is a good
> thing for performance so unless it's found to be needed to use another
> address space here I'm happy with this as it matches what other similar
> devices do and it seems to work. Maybe a separate address space is only
> really needed if we have an iommu?
Hi Zoltan,
It is possible for bonito to remap PCI address space so maybe it's essential
for bonito.
Appreciate for your work. I'm going to help with reviewing as well.
>
> Regards,
> BALATON Zoltan
--
- Jiaxun
- [PATCH v2 07/13] vt82c686: Simplify vt82c686b_realize(), (continued)
- [PATCH v2 07/13] vt82c686: Simplify vt82c686b_realize(), BALATON Zoltan, 2021/01/09
- [PATCH v2 05/13] vt82c686: Set user_creatable=false for VT82C686B_PM, BALATON Zoltan, 2021/01/09
- [PATCH v2 13/13] vt82c686: Add emulation of VT8231 south bridge, BALATON Zoltan, 2021/01/09
- [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, BALATON Zoltan, 2021/01/09
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, Philippe Mathieu-Daudé, 2021/01/09
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, BALATON Zoltan, 2021/01/09
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, Philippe Mathieu-Daudé, 2021/01/10
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, BALATON Zoltan, 2021/01/10
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge,
Jiaxun Yang <=
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, BALATON Zoltan, 2021/01/11
- Re: [PATCH v2 08/13] vt82c686: Move creation of ISA devices to the ISA bridge, Philippe Mathieu-Daudé, 2021/01/25
[PATCH v2 06/13] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it, BALATON Zoltan, 2021/01/09
[PATCH v2 10/13] vt82c686: Implement control of serial port io ranges via config regs, BALATON Zoltan, 2021/01/09
[PATCH v2 09/13] vt82c686: Fix superio_cfg_{read,write}() functions, BALATON Zoltan, 2021/01/09
[PATCH v2 11/13] vt82c686: QOM-ify superio related functionality, BALATON Zoltan, 2021/01/09