[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 15/23] paaudio: wait until the playback stream is ready
From: |
Volker Rümelin |
Subject: |
[PATCH 15/23] paaudio: wait until the playback stream is ready |
Date: |
Sun, 10 Jan 2021 11:02:31 +0100 |
Don't call pa_stream_writable_size() in qpa_get_buffer_out()
before the playback stream is ready. This prevents a lot of the
following pulseaudio error messages.
pulseaudio: pa_stream_writable_size failed
pulseaudio: Reason: Bad state
To reproduce start qemu with
-parallel none -device gus,audiodev=audio0 -audiodev pa,id=audio0
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
audio/paaudio.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/audio/paaudio.c b/audio/paaudio.c
index 1a7252b16d..4a1ffda753 100644
--- a/audio/paaudio.c
+++ b/audio/paaudio.c
@@ -214,6 +214,12 @@ static void *qpa_get_buffer_out(HWVoiceOut *hw, size_t
*size)
CHECK_DEAD_GOTO(c, p->stream, unlock_and_fail,
"pa_threaded_mainloop_lock failed\n");
+ if (pa_stream_get_state(p->stream) != PA_STREAM_READY) {
+ /* wait for stream to become ready */
+ l = 0;
+ ret = NULL;
+ goto unlock;
+ }
l = pa_stream_writable_size(p->stream);
CHECK_SUCCESS_GOTO(c, l != (size_t) -1, unlock_and_fail,
@@ -224,6 +230,7 @@ static void *qpa_get_buffer_out(HWVoiceOut *hw, size_t
*size)
CHECK_SUCCESS_GOTO(c, r >= 0, unlock_and_fail,
"pa_stream_begin_write failed\n");
+unlock:
pa_threaded_mainloop_unlock(c->mainloop);
if (*size > l) {
*size = l;
--
2.26.2
- Re: [PATCH 07/23] sdlaudio: replace legacy functions with modern ones, (continued)
- [PATCH 03/23] sdlaudio: add -audiodev sdl,out.buffer-count option, Volker Rümelin, 2021/01/10
- [PATCH 10/23] audio: break generic buffer dependency on mixing-engine, Volker Rümelin, 2021/01/10
- [PATCH 08/23] audio: split pcm_ops function get_buffer_in, Volker Rümelin, 2021/01/10
- [PATCH 09/23] sdlaudio: add recording functions, Volker Rümelin, 2021/01/10
- [PATCH 11/23] sdlaudio: enable (in|out).mixing-engine=off, Volker Rümelin, 2021/01/10
- [PATCH 13/23] paaudio: avoid to clip samples multiple times, Volker Rümelin, 2021/01/10
- [PATCH 14/23] paaudio: wait for PA_STREAM_READY in qpa_write(), Volker Rümelin, 2021/01/10
- [PATCH 15/23] paaudio: wait until the playback stream is ready,
Volker Rümelin <=
- [PATCH 12/23] audio: remove remaining unused plive code, Volker Rümelin, 2021/01/10
- [PATCH 16/23] paaudio: remove unneeded code, Volker Rümelin, 2021/01/10
- [PATCH 18/23] paaudio: limit minreq to 75% of audio timer_rate, Volker Rümelin, 2021/01/10
- [PATCH 20/23] dsoundaudio: replace GetForegroundWindow(), Volker Rümelin, 2021/01/10
- [PATCH 17/23] paaudio: comment bugs in functions qpa_init_*, Volker Rümelin, 2021/01/10
- [PATCH 19/23] paaudio: send recorded data in smaller chunks, Volker Rümelin, 2021/01/10
- [PATCH 21/23] dsoundaudio: rename dsound_open(), Volker Rümelin, 2021/01/10
- [PATCH 22/23] dsoundaudio: enable f32 audio sample format, Volker Rümelin, 2021/01/10
- [PATCH 23/23] dsoundaudio: fix log message, Volker Rümelin, 2021/01/10
- Re: [PATCH 00/23] next round of audio patches, no-reply, 2021/01/10