[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vnc: add qmp to support change authz
From: |
Zihao Chang |
Subject: |
Re: [PATCH] vnc: add qmp to support change authz |
Date: |
Fri, 8 Jan 2021 15:09:14 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
Hi,
On 2021/1/8 0:04, Gerd Hoffmann wrote:
> Hi,
>
>> This patch add a new qmp 'change-vnc-authz' to support change the
>> tls/sasl authz of vm. If index='', unset tlsauthzid/sasl.authzid
>> {
>> "execute":"change-vnc-authz",
>> "arguments":{
>> "index":"object-authz-id",
>> "type":"tls/sasl"
>> }
>> }
>
>> +##
>> +# @change-vnc-authz:
>> +#
>> +# Change the VNC server authz.
>> +#
>> +# @type: the new authz type to use with VNC authentication
>> +# @index: the new authz object index to use with VNC authentication
>> +#
>> +# Since: 5.2
>> +#
>> +##
>> +{ 'command': 'change-vnc-authz',
>> + 'data': { 'type' : 'str',
>> + 'index': 'str'},
>> + 'if': 'defined(CONFIG_VNC_SASL)' }
>
> type should be an enum I think.
It is a good idea to set type to enum, I will fix it in the next version.
> Also index should be an int (and possibly an optional argument so you
> can just not specify index to unset).
>
Index is the id of authz object(myauthz, user can set it as they wanted), may
not use int.
-object authz-simple,id=myauthz,identity=test1
> take care,
> Gerd
>
> .
>
BTW, Daniel P . Berrangé suggests that all property set QMP commands should be
integrated
as an general purpose "display_update" QMP command. That's really a good idea.
This may
take longer time to design and code. Will we not think about adding new
property set QMP
until the general purpose "display_update" QMP is ready?
https://lists.nongnu.org/archive/html/qemu-devel/2021-01/msg00941.html
Thanks,
Zihao