[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 02/12] vt82c686: Reorganise code
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 02/12] vt82c686: Reorganise code |
Date: |
Thu, 7 Jan 2021 09:07:59 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 1/6/21 10:13 PM, BALATON Zoltan wrote:
> Move lines around so that object definitions become consecutive and
> not scattered around. This brings functions belonging to an object
> together so it's clearer what is defined and what parts belong to
> which object.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/isa/vt82c686.c | 279 +++++++++++++++++++++++-----------------------
> 1 file changed, 140 insertions(+), 139 deletions(-)
...
> static void vt82c686b_realize(PCIDevice *d, Error **errp)
> {
> VT82C686BISAState *s = VT82C686B_ISA(d);
> @@ -354,6 +353,7 @@ static const TypeInfo via_info = {
> },
> };
>
> +
> static void vt82c686b_superio_class_init(ObjectClass *klass, void *data)
> {
> ISASuperIOClass *sc = ISA_SUPERIO_CLASS(klass);
> @@ -372,11 +372,12 @@ static const TypeInfo via_superio_info = {
> .class_init = vt82c686b_superio_class_init,
> };
>
> +
Spurious extra-lines?
Reviewed with 'git-diff --color-moved=dimmed-zebra':
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH 05/12] vt82c686: Make vt82c686b-pm an abstract base class and add vt8231-pm based on it, (continued)
- [PATCH 06/12] vt82c686: Simplify vt82c686b_realize(), BALATON Zoltan, 2021/01/06
- [PATCH 04/12] vt82c686: Fix up power management io base and config, BALATON Zoltan, 2021/01/06
- [PATCH 07/12] vt82c686: Move creation of ISA devices to the ISA bridge, BALATON Zoltan, 2021/01/06
- [PATCH 01/12] vt82c686: Move superio memory region to SuperIOConfig struct, BALATON Zoltan, 2021/01/06
- [PATCH 09/12] vt82c686: Implement control of serial port io ranges via config regs, BALATON Zoltan, 2021/01/06
- [PATCH 11/12] vt82c686: Add VT8231_SUPERIO based on VIA_SUPERIO, BALATON Zoltan, 2021/01/06
- [PATCH 03/12] vt82c686: Fix SMBus IO base and configuration registers, BALATON Zoltan, 2021/01/06
- [PATCH 02/12] vt82c686: Reorganise code, BALATON Zoltan, 2021/01/06
- Re: [PATCH 02/12] vt82c686: Reorganise code,
Philippe Mathieu-Daudé <=
- [PATCH 10/12] vt82c686: QOM-ify superio related functionality, BALATON Zoltan, 2021/01/06
- [PATCH 08/12] vt82c686: Fix superio_cfg_{read,write}() functions, BALATON Zoltan, 2021/01/06
- [PATCH 12/12] vt82c686: Add emulation of VT8231 south bridge, BALATON Zoltan, 2021/01/06