Re: [PATCH] linux-user: Add ETHTOOL ioctl

[Laurent Vivier]

Hi Matevz,

Le 05/01/2021 à 20:24, Matevz Langus a écrit :
> Handling of ETHTOOL ioctl was not implemented.
> 
> Signed-off-by: Matevz Langus <matevz.langus@borea.si>
> ---
>  linux-user/ioctls.h       | 1 +
>  linux-user/syscall_defs.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h
> index 661b5daa9f..3e5c220199 100644
> --- a/linux-user/ioctls.h
> +++ b/linux-user/ioctls.h
> @@ -362,6 +362,7 @@
>    IOCTL(SIOCSIFHWADDR, IOC_W, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
>    IOCTL(SIOCGIFTXQLEN, IOC_W | IOC_R, 
> MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
>    IOCTL(SIOCSIFTXQLEN, IOC_W, MK_PTR(MK_STRUCT(STRUCT_sockaddr_ifreq)))
> +  IOCTL(SIOCETHTOOL, IOC_R | IOC_W, MK_PTR(MK_STRUCT(STRUCT_ptr_ifreq)))
>    IOCTL(SIOCGIFMETRIC, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
>    IOCTL(SIOCSIFMETRIC, IOC_W, MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
>    IOCTL(SIOCGIFMTU, IOC_W | IOC_R, MK_PTR(MK_STRUCT(STRUCT_int_ifreq)))
> diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h
> index a00bfc2647..d9301fecc9 100644
> --- a/linux-user/syscall_defs.h
> +++ b/linux-user/syscall_defs.h
> @@ -903,6 +903,7 @@ struct target_rtc_pll_info {
> 
>  #define TARGET_SIOCGIFTXQLEN   0x8942          /* Get the tx queue length    
>   */
>  #define TARGET_SIOCSIFTXQLEN   0x8943          /* Set the tx queue length    
>   */
> +#define TARGET_SIOCETHTOOL     0x8946          /* Ethtool interface          
>   */
> 
>  /* ARP cache control calls. */
>  #define TARGET_OLD_SIOCDARP    0x8950          /* old delete ARP table entry 
>   */

Thank you for your patch but the solution is more complex.

Shu-Chun has already sent a patch last month to address the problem:

https://patchew.org/QEMU/20201218214142.3673709-1-scw@google.com/

Thanks,
Laurent