qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_vir


From: Willian Rampazzo
Subject: Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio
Date: Tue, 5 Jan 2021 10:52:26 -0300

On Tue, Jan 5, 2021 at 9:46 AM Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The read binary data as text via a PPM export of the frame buffer
> seems a bit sketchy and it did blow up in the real world when the
> assertion failed:
>
>   https://gitlab.com/qemu-project/qemu/-/jobs/943183183
>
> However short of cleaning up the test to be more binary focused at
> least limit the attempt to dump the whole file as hexified zeros in
> the logs.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  tests/acceptance/machine_s390_ccw_virtio.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Willian Rampazzo <willianr@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]