[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ

From: Mark Cave-Ayland
Subject: Re: [PATCH 0/2] sparc/leon3: Make grlib-irqmp handle its own inbound IRQ lines
Date: Tue, 5 Jan 2021 13:04:50 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 12/12/2020 14:41, Peter Maydell wrote:

Currently the GRLIB_IRQMP device is used in one place (the leon3
board), but instead of the device providing inbound gpio lines for
the board to wire up, the board code itself calls
qemu_allocate_irqs() with the handler function being a set_irq
function defined in the code for the device.

Patch one in this series refactors this into the standard setup of a
device having input gpio lines.  The main motivation here is that it
squashes a trivial Coverity memory leak warning.  Patch two just
removes a stray unused typedef that I noticed in passing.

Incidentally I suspect the irqmp_ack logic could also be done more
neatly, but I didn't feel like getting into that at this point.

Tested by booting the 'buildroot' image downloadable from
and runnable with
  ./build/sparc-all/qemu-system-sparc -M leon3_generic -display none -serial 
stdio -kernel image.ram

-- PMM

Peter Maydell (2):
   hw/sparc: Make grlib-irqmp device handle its own inbound IRQ lines
   include/hw/sparc/grlib.h: Remove unused set_pil_in_fn typedef

  include/hw/sparc/grlib.h |  4 ----
  hw/intc/grlib_irqmp.c    |  5 ++++-
  hw/sparc/leon3.c         | 21 +++++++++------------
  3 files changed, 13 insertions(+), 17 deletions(-)

Frederic/Fabien - any chance of a Reviewed-by or Acked-by tag from one of you? If so, I can send this as part of an upcoming SPARC PR.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]