Re: [PATCH] tests/docker: Include 'ccache' in Debian base image

[Alex Bennée]

Philippe Mathieu-Daudé <f4bug@amsat.org> writes:

> Hi,
>
> On 12/14/20 2:39 PM, Philippe Mathieu-Daudé wrote:
>> On 12/14/20 6:44 AM, Thomas Huth wrote:
>>> On 13/12/2020 22.16, Philippe Mathieu-Daudé wrote:
>>>> Include the 'ccache' package to speed up compilation.
>>>>
>>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>>> ---
>>>>  tests/docker/dockerfiles/debian10.docker | 1 +
>>>>  1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/tests/docker/dockerfiles/debian10.docker 
>>>> b/tests/docker/dockerfiles/debian10.docker
>>>> index 73a3caac9cd..9d42b5a4b81 100644
>>>> --- a/tests/docker/dockerfiles/debian10.docker
>>>> +++ b/tests/docker/dockerfiles/debian10.docker
>>>> @@ -20,6 +20,7 @@ RUN apt update && \
>>>>          bc \
>>>>          build-essential \
>>>>          ca-certificates \
>>>> +        ccache \
>>>>          clang \
>>>>          dbus \
>>>>          gdb-multiarch \
>>>
>>> Don't you need some additional setup for this? Like caching the
>>> corresponding directory during CI runs?
>> 
>> I hadn't looked at CI (too many CI series in fly).
>> 
>> w.r.t. Docker this is in use since 4 years, see:
>> 324027c24cd ("Makefile: Rules for docker testing")
>> 36ac78e65a0 ("docker: Don't mount ccache db if NOUSER=1")
>> 
>> I suppose we forgot the package when introducing debian10
>> base image in commit d6db2a1cdf6 ("docker: add
>> debian-buster-arm64-cross").
>
> Should I do something else with this patch?

Queued to testing/next, thanks.

-- 
Alex Bennée