[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: Propagate gnutls dependency

From: Peter Maydell
Subject: Re: [PATCH] meson: Propagate gnutls dependency
Date: Mon, 4 Jan 2021 17:51:52 +0000

On Mon, 4 Jan 2021 at 17:49, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 04/01/21 16:19, Peter Maydell wrote:
> > Does this work recursively? For instance monitor/qmp-cmds.c
> > needs the gnutls CFLAGS because:
> >   * qmp-cmds.c includes ui/vnc.h
> >   * ui/vnc.h includes include/crypto/tlssession.h
> >   * include/crypto/tlssession.h includes gnutls.h
> >
> > I don't see anything in monitor/meson.build that says "qmp-cmds.c
> > needs whatever ui's dependencies are".
> Hmm, I would have thought it would be handled, but Roman said otherwise.
>   I'll look into it, at worst we can fix Meson and temporarily apply
> Roman's patch until it makes it into a release.

NB that for qmp-cmds.c in particular
will avoid the accidental inclusion of <gnutls.h>, though I guess
in principle the monitor still needs to say it depends on ui...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]