[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci
From: |
g00517791 |
Subject: |
[PATCH 4/8] spapr_pci: Fix memory leak of vmstate_spapr_pci |
Date: |
Sat, 26 Dec 2020 18:33:43 +0800 |
From: Jinhao Gao <gaojinhao@huawei.com>
When VM migrate VMState of spapr_pci, the field(msi_devs) of spapr_pci
having a flag of VMS_ALLOC need to allocate memory. If the src doesn't free
memory of msi_devs in SaveStateEntry of spapr_pci after QEMUFile save
VMState of spapr_pci, it may result in memory leak of msi_devs. We add the
post_save func to free memory, which prevents memory leak.
Signed-off-by: Jinhao Gao <gaojinhao@huawei.com>
---
hw/ppc/spapr_pci.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 76d7c91e9c..1b2b940606 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -2173,6 +2173,16 @@ static int spapr_pci_pre_save(void *opaque)
return 0;
}
+static int spapr_pci_post_save(void *opaque)
+{
+ SpaprPhbState *sphb = opaque;
+
+ g_free(sphb->msi_devs);
+ sphb->msi_devs = NULL;
+ sphb->msi_devs_num = 0;
+ return 0;
+}
+
static int spapr_pci_post_load(void *opaque, int version_id)
{
SpaprPhbState *sphb = opaque;
@@ -2205,6 +2215,7 @@ static const VMStateDescription vmstate_spapr_pci = {
.version_id = 2,
.minimum_version_id = 2,
.pre_save = spapr_pci_pre_save,
+ .post_save = spapr_pci_post_save,
.post_load = spapr_pci_post_load,
.fields = (VMStateField[]) {
VMSTATE_UINT64_EQUAL(buid, SpaprPhbState, NULL),
--
2.23.0
[PATCH 2/8] virtio-net: Fix memory leak of vmstate_virtio_net_rss, g00517791, 2020/12/26
[PATCH 3/8] spapr: Fix memory leak of vmstate_spapr_event_entry, g00517791, 2020/12/26
[PATCH 7/8] tpm_emulator: Fix memory leak of vmstate_tpm_emulator, g00517791, 2020/12/26
[PATCH 5/8] savevm: Fix memory leak of vmstate_configuration, g00517791, 2020/12/26
Re: [PATCH 0/8] Fix memory leak of some device state in migration, no-reply, 2020/12/26