[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] hvf: guard xgetbv call.
From: |
Hill Ma |
Subject: |
[PATCH] hvf: guard xgetbv call. |
Date: |
Fri, 18 Dec 2020 18:13:47 -0800 |
This prevents illegal instruction on cpus do not support xgetbv.
Buglink: https://bugs.launchpad.net/qemu/+bug/1758819
Signed-off-by: Hill Ma <maahiuzeon@gmail.com>
---
target/i386/hvf/x86_cpuid.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/target/i386/hvf/x86_cpuid.c b/target/i386/hvf/x86_cpuid.c
index a6842912f5..b4b7111fc3 100644
--- a/target/i386/hvf/x86_cpuid.c
+++ b/target/i386/hvf/x86_cpuid.c
@@ -100,11 +100,16 @@ uint32_t hvf_get_supported_cpuid(uint32_t func, uint32_t
idx,
break;
case 0xD:
if (idx == 0) {
- uint64_t host_xcr0 = xgetbv(0);
- uint64_t supp_xcr0 = host_xcr0 & (XSTATE_FP_MASK | XSTATE_SSE_MASK
|
+ uint64_t supp_xcr0 = XSTATE_FP_MASK | XSTATE_SSE_MASK |
XSTATE_YMM_MASK | XSTATE_BNDREGS_MASK |
XSTATE_BNDCSR_MASK | XSTATE_OPMASK_MASK |
- XSTATE_ZMM_Hi256_MASK |
XSTATE_Hi16_ZMM_MASK);
+ XSTATE_ZMM_Hi256_MASK | XSTATE_Hi16_ZMM_MASK;
+ if ((ecx & CPUID_EXT_AVX) &&
+ (ecx & CPUID_EXT_XSAVE) &&
+ (ecx & CPUID_EXT_OSXSAVE)) {
+ uint64_t host_xcr0 = xgetbv(0);
+ supp_xcr0 &= host_xcr0;
+ }
eax &= supp_xcr0;
} else if (idx == 1) {
hv_vmx_read_capability(HV_VMX_CAP_PROCBASED2, &cap);
--
2.20.1 (Apple Git-117)
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] hvf: guard xgetbv call.,
Hill Ma <=