[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/13] qapi/introspect.py: use _make_tree for features nodes
From: |
John Snow |
Subject: |
[PATCH v3 02/13] qapi/introspect.py: use _make_tree for features nodes |
Date: |
Wed, 16 Dec 2020 20:53:32 -0500 |
At present, we open-code this in _make_tree itself; but if the structure
of the tree changes, this is brittle. Use an explicit recursive call to
_make_tree when appropriate to help keep the interior node typing
consistent.
Signed-off-by: John Snow <jsnow@redhat.com>
---
scripts/qapi/introspect.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introspect.py
index 43ab4be1f77..3295a15c98e 100644
--- a/scripts/qapi/introspect.py
+++ b/scripts/qapi/introspect.py
@@ -30,7 +30,9 @@ def _make_tree(obj, ifcond, features, extra=None):
if ifcond:
extra['if'] = ifcond
if features:
- obj['features'] = [(f.name, {'if': f.ifcond}) for f in features]
+ obj['features'] = [
+ _make_tree(f.name, f.ifcond, None) for f in features
+ ]
if extra:
return (obj, extra)
return obj
--
2.26.2
- [PATCH v3 00/13] qapi: static typing conversion, pt2, John Snow, 2020/12/16
- [PATCH v3 03/13] qapi/introspect.py: add _gen_features helper, John Snow, 2020/12/16
- [PATCH v3 01/13] qapi/introspect.py: assert schema is not None, John Snow, 2020/12/16
- [PATCH v3 02/13] qapi/introspect.py: use _make_tree for features nodes,
John Snow <=
- [PATCH v3 06/13] qapi/introspect.py: replace 'extra' dict with 'comment' argument, John Snow, 2020/12/16
- [PATCH v3 04/13] qapi/introspect.py: guard against ifcond/comment misuse, John Snow, 2020/12/16
- [PATCH v3 05/13] qapi/introspect.py: Unify return type of _make_tree(), John Snow, 2020/12/16
- [PATCH v3 08/13] qapi/introspect.py: create a typed 'Annotated' data strutcure, John Snow, 2020/12/16
- [PATCH v3 09/13] qapi/introspect.py: improve _tree_to_qlit error message, John Snow, 2020/12/16
- [PATCH v3 10/13] qapi/introspect.py: improve readability of _tree_to_qlit, John Snow, 2020/12/16
- [PATCH v3 11/13] qapi/introspect.py: add type hint annotations, John Snow, 2020/12/16
- [PATCH v3 12/13] qapi/instrospect.py: add introspect.json dummy types, John Snow, 2020/12/16
- [PATCH v3 13/13] qapi/introspect.py: Add docstring to _tree_to_qlit, John Snow, 2020/12/16
- [PATCH v3 07/13] qapi/introspect.py: Introduce preliminary tree typing, John Snow, 2020/12/16