Re: [PATCH] tests: update for rename of CentOS8 PowerTools repo

[Mark Cave-Ayland]

On 16/12/2020 16:10, Peter Maydell wrote:

> On Wed, 16 Dec 2020 at 14:21, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > This was intentionally renamed recently to be all lowercase:
> >
> > https://bugs.centos.org/view.php?id=17920
> > https://wiki.centos.org/Manuals/ReleaseNotes/CentOS8.2011#Yum_repo_file_and_repoid_changes
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >
> > This needs to be merged asap, as CI will break for anyone whose branch
> > triggers a rebuild of the centos container image.
> >
> > eg current broken git master:
> >
> >    https://gitlab.com/berrange/qemu/-/jobs/915852165
> >
> > vs with this fix
> >
> >    https://gitlab.com/berrange/qemu/-/jobs/915862731
> >
> >   tests/docker/dockerfiles/centos8.docker | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/docker/dockerfiles/centos8.docker 
> > b/tests/docker/dockerfiles/centos8.docker
> > index 54bc6d54cd..06b67962fd 100644
> > --- a/tests/docker/dockerfiles/centos8.docker
> > +++ b/tests/docker/dockerfiles/centos8.docker
> > @@ -31,6 +31,6 @@ ENV PACKAGES \
> >       zlib-devel
> >
> >   RUN dnf install -y dnf-plugins-core && \
> > -  dnf config-manager --set-enabled PowerTools && \
> > +  dnf config-manager --set-enabled powertools && \
> >     dnf install -y $PACKAGES
> >   RUN rpm -q $PACKAGES | sort > /packages.txt
>
> I tried a test merge of this but it fails in Gitlab CI:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/916041167
>
> #6 7.706 Error: No matching repo to modify: powertools.
> #6 ERROR: executor failed running [/bin/sh -c dnf install -y
> dnf-plugins-core && dnf config-manager --set-enabled powertools && dnf
> install -y $PACKAGES]: exit code: 1

That's odd. Could it be that gitlab is still caching the old image here?


ATB,

Mark.