qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG b


From: Paolo Bonzini
Subject: Re: [PATCH 3/3] trace: do not include TCG helper tracepoints in no-TCG builds
Date: Wed, 16 Dec 2020 16:22:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

On 16/12/20 16:13, Richard Henderson wrote:
@@ -71,7 +71,7 @@ foreach d : [
                  input: meson.project_source_root() / 'trace-events',
                  command: [ tracetool, '--group=root', 
'--format=@0@'.format(d[1]), '@INPUT@' ],
                  capture: true)
-  specific_ss.add(gen)
+  specific_ss.add(when: 'CONFIG_TCG', if_true: gen)
  endforeach

Sure, unless it makes more sense to conditionalize the entire loop, so that
those targets aren't even created?

The targets exist but the files won't be created (the rules will be in build.ninja but they'll be orphan).

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]