[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] audio: remove qemu_spice_audio_init()
From: |
Volker Rümelin |
Subject: |
Re: [PATCH 1/2] audio: remove qemu_spice_audio_init() |
Date: |
Tue, 15 Dec 2020 21:03:01 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 |
>>> + if (using_spice) {
>>> + /*
>>> + * When using spice allow the spice audio driver being picked
>>> + * as default.
>>> + *
>>> + * Temporary hack. Using audio devices without explicit
>>> + * audiodev= property is already deprecated. Same goes for
>>> + * the -soundhw switch. Once this support gets finally
>>> + * removed we can also drop the concept of a default audio
>>> + * backend and this can go away.
>>> + */
>>> + driver = audio_driver_lookup("spice");
>>> + driver->can_be_default = 1;
>> fyi, one of my libvirt/QEMU guests now segfaults here.
>> See: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=977301
> Hmm, surely doesn't hurt to add a "if (driver)" check here.
>
> I'm wondering though how you end up with spice being enabled
> but spiceaudio driver not being available. There is no separate
> config switch so you should have both spice + spiceaudio or
> none of them ...
Hi Gerd,
I can reproduce this problem on my openSUSE 15.2 system. I just have to
uninstall the qemu-audio-spice rpm package.
One could argue this is a packaging problem.
With best regards
Volker