Re: [PULL 1/2] test-char: abort on serial test error

[Eduardo Habkost]

On Sun, Dec 13, 2020 at 11:51:05PM +0100, Philippe Mathieu-Daudé wrote:
> On 7/28/20 4:31 PM, Marc-André Lureau wrote:
> > We are having issues debugging and bisecting this issue that happen
> > mostly on patchew. Let's make it abort where it failed to gather some
> > new informations.
> 
> "good" news, this started to fail on Gitlab (centos7):
> 
> Running test test-char
> Unexpected error in object_property_try_add() at ../qom/object.c:1220:
> attempt to add duplicate property 'serial-id' to object (type 'container')
> ERROR test-char - too few tests run (expected 38, got 9)
> make: *** [run-test-86] Error 1
> 
> https://gitlab.com/philmd/qemu/-/jobs/908114388
> https://gitlab.com/philmd/qemu/-/jobs/908114389
> https://gitlab.com/philmd/qemu/-/jobs/908114390

Do we have any clue what could be causing this?  After looking at
the code, it smells like memory corruption.

At first, I thought it could be due to the multi-threaded test
cases, but the test binary seems to be crashing before the
multi-threaded test cases have an opportunity to run.

> 
> > 
> > Suggested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> >  tests/test-char.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/test-char.c b/tests/test-char.c
> > index 614bdac2df..d35cc839bc 100644
> > --- a/tests/test-char.c
> > +++ b/tests/test-char.c
> > @@ -1200,7 +1200,7 @@ static void char_serial_test(void)
> >  
> >      /* test tty alias */
> >      qemu_opt_set(opts, "backend", "tty", &error_abort);
> > -    chr = qemu_chr_new_from_opts(opts, NULL, NULL);
> > +    chr = qemu_chr_new_from_opts(opts, NULL, &error_abort);
> >      g_assert_nonnull(chr);
> >      object_unparent(OBJECT(chr));
> >  
> > 
> 
> 

-- 
Eduardo