[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] block/nfs: fix int overflow in nfs_client_open_qdict
From: |
Kevin Wolf |
Subject: |
Re: [PATCH] block/nfs: fix int overflow in nfs_client_open_qdict |
Date: |
Tue, 15 Dec 2020 17:03:36 +0100 |
Am 10.12.2020 um 10:00 hat Stefano Garzarella geschrieben:
> On Wed, Dec 09, 2020 at 01:17:35PM +0100, Peter Lieven wrote:
> > nfs_client_open returns the file size in sectors. This effectively
> > makes it impossible to open files larger than 1TB.
> >
> > Fixes: a1a42af422d46812f1f0cebe6b230c20409a3731
> > Cc: qemu-stable@nongnu.org
> > Signed-off-by: Peter Lieven <pl@kamp.de>
> > ---
> > block/nfs.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> The issue seems to be pre-existing to the commit
> a1a42af422d46812f1f0cebe6b230c20409a3731, but of course that commit touched
> this code and this patch would not apply before, so it seems okay to me:
I think it's commit c22a0345, which is the one right before a1a42af4.
I'll update the commit message accordingly.
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Thanks, applied to the block branch.
Kevin