[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message
From: |
Eduardo Habkost |
Subject: |
[PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message |
Date: |
Fri, 11 Dec 2020 17:05:03 -0500 |
All other qdev property error messages use "<type>.<property>"
instead of "<id>.<property>". Change set_size32() for consistency,
and to make the code not specific to TYPE_DEVICE.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 67ae19df05..daf844c2d3 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -542,7 +542,7 @@ static void set_size32(Object *obj, Visitor *v, const char
*name, void *opaque,
error_setg(errp,
"Property %s.%s doesn't take value %" PRIu64
" (maximum: %u)",
- dev->id ? : "", name, value, UINT32_MAX);
+ object_get_typename(obj), name, value, UINT32_MAX);
return;
}
--
2.28.0
- [PATCH v4 00/32] qdev property code cleanup, Eduardo Habkost, 2020/12/11
- [PATCH v4 02/32] cpu: Move cpu_common_props to hw/core/cpu.c, Eduardo Habkost, 2020/12/11
- [PATCH v4 01/32] cs4231: Get rid of empty property array, Eduardo Habkost, 2020/12/11
- [PATCH v4 04/32] qdev: Check dev->realized at set_size(), Eduardo Habkost, 2020/12/11
- [PATCH v4 03/32] qdev: Move property code to qdev-properties.[ch], Eduardo Habkost, 2020/12/11
- [PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message,
Eduardo Habkost <=
- [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/12/11
- [PATCH v4 07/32] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 08/32] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 09/32] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/12/11
- [PATCH v4 11/32] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 10/32] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 12/32] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/12/11