Re: [PATCH v11 18/25] cpu: Move synchronize_from_tb() to tcg_ops

[Richard Henderson]

On 12/11/20 11:47 AM, Claudio Fontana wrote:
>> What is it that you thought you needed from core/cpu.h anyway?
...
>>>> Are you sure that splitting out hw/core/tcg-cpu-ops.h from hw/core/cpu.h in
>>>> patch 15 is even useful?
>>>
>>> it avoids a huge #ifdef CONFIG_TCG
>>
>> So?  The question should be: is it useful on its own, and I think the answer 
>> to
>> that is clearly not.  Thus it should not pretend to be a standalone header 
>> file.
>>
> 
> The whole point of the exercise is to sort out what is tcg specific and
> only compile it under CONFIG_TCG.
> 
> Having everything inside cpu.h wrapped in a 100 line #ifdef is not
> particularly readable or discoverable, so I think it is actually useful
> for understanding purposes to have it separate...
Ok, so separate, but perhaps not standalone.

My question above remains: what did you need from core/cpu.h?  Was it in fact
just a typedef for CPUState?
In which case "qemu/typedefs.h" is a better choice.


r~