Re: [PATCH v11 14/25] cpu: Remove unnecessary noop methods

[Philippe Mathieu-Daudé]

On 12/11/20 9:31 AM, Claudio Fontana wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
> 

Either add:

"In the previous commits we made cpu_exec_* and
 debug_excp_handler handlers optional, we can now
 remove these no-op handlers."

Or squash in each commit...

Anyhow:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>  hw/core/cpu.c | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/hw/core/cpu.c b/hw/core/cpu.c
> index 576fa1d7ba..994a12cb35 100644
> --- a/hw/core/cpu.c
> +++ b/hw/core/cpu.c
> @@ -199,15 +199,6 @@ static bool cpu_common_virtio_is_big_endian(CPUState 
> *cpu)
>      return target_words_bigendian();
>  }
>  
> -static void cpu_common_noop(CPUState *cpu)
> -{
> -}
> -
> -static bool cpu_common_exec_interrupt(CPUState *cpu, int int_req)
> -{
> -    return false;
> -}
> -
>  #if !defined(CONFIG_USER_ONLY)
>  GuestPanicInformation *cpu_get_crash_info(CPUState *cpu)
>  {
> @@ -410,11 +401,7 @@ static void cpu_class_init(ObjectClass *klass, void 
> *data)
>      k->gdb_read_register = cpu_common_gdb_read_register;
>      k->gdb_write_register = cpu_common_gdb_write_register;
>      k->virtio_is_big_endian = cpu_common_virtio_is_big_endian;
> -    k->debug_excp_handler = cpu_common_noop;
>      k->debug_check_watchpoint = cpu_common_debug_check_watchpoint;
> -    k->cpu_exec_enter = cpu_common_noop;
> -    k->cpu_exec_exit = cpu_common_noop;
> -    k->cpu_exec_interrupt = cpu_common_exec_interrupt;
>      k->adjust_watchpoint_address = cpu_adjust_watchpoint_address;
>      set_bit(DEVICE_CATEGORY_CPU, dc->categories);
>      dc->realize = cpu_common_realizefn;
>