[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs
From: |
Zihao Chang |
Subject: |
Re: [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs |
Date: |
Fri, 11 Dec 2020 10:11:53 +0800 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 |
On 2020/12/11 0:31, Markus Armbruster wrote:
> From: Zihao Chang <changzihao1@huawei.com>
>
> Fix the example of add qmp hello-world example.
> Without ":", make will report error:
> ../qapi/misc.json:573:2: line should end with ':'
>
> Signed-off-by: Zihao Chang <changzihao1@huawei.com>
> Message-Id: <20201201143308.1626-1-changzihao1@huawei.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/devel/writing-qmp-commands.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/devel/writing-qmp-commands.txt
> b/docs/devel/writing-qmp-commands.txt
> index 46a6c48683..28984686c9 100644
> --- a/docs/devel/writing-qmp-commands.txt
> +++ b/docs/devel/writing-qmp-commands.txt
> @@ -243,7 +243,7 @@ There are many examples of such documentation in the
> schema file already, but
> here goes "hello-world"'s new entry for qapi/misc.json:
I follow the steps of hello world demo and find the problem, other entries seem
to have the same
problem. Because I didn't test the other entries, I only modified hello world.
Maybe I can test
them later.
>
> ##
> -# @hello-world
> +# @hello-world:
> #
> # Print a client provided string to the standard output stream.
> #
>
- [PULL 12/13] qapi: Normalize version references x.y.0 to just x.y, (continued)
- [PULL 12/13] qapi: Normalize version references x.y.0 to just x.y, Markus Armbruster, 2020/12/10
- [PULL 04/13] block: Improve some block-commit, block-stream error messages, Markus Armbruster, 2020/12/10
- [PULL 02/13] qerror: Drop unused QERR_ macros, Markus Armbruster, 2020/12/10
- [PULL 10/13] qom: Improve {qom, device}-list-properties error messages, Markus Armbruster, 2020/12/10
- [PULL 01/13] Clean up includes, Markus Armbruster, 2020/12/10
- [PULL 06/13] ui: Improve a client_migrate_info error message, Markus Armbruster, 2020/12/10
- [PULL 11/13] Tweak a few "Parameter 'NAME' expects THING" error message, Markus Armbruster, 2020/12/10
- [PULL 03/13] qerror: Eliminate QERR_ macros used in just one place, Markus Armbruster, 2020/12/10
- [PULL 08/13] qga: Replace an unreachable error by abort(), Markus Armbruster, 2020/12/10
- [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs, Markus Armbruster, 2020/12/10
- Re: [PULL 13/13] docs/devel/writing-qmp-commands.txt: Fix docs,
Zihao Chang <=
- [PULL 07/13] ui: Tweak a client_migrate_info error message, Markus Armbruster, 2020/12/10
- [PULL 09/13] qga: Tweak a guest-shutdown error message, Markus Armbruster, 2020/12/10
- [PULL 05/13] ui: Improve some set_passwd, expire_password error messages, Markus Armbruster, 2020/12/10
- Re: [PULL 00/13] Miscellaneous patches for 2020-12-10, Peter Maydell, 2020/12/10