qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram


From: Pankaj Gupta
Subject: Re: [PATCH v2 07/10] softmmu/physmem: Don't use atomic operations in ram_block_discard_(disable|require)
Date: Thu, 10 Dec 2020 16:20:08 +0100

> >>  bool ram_block_discard_is_disabled(void)
> >>  {
> >> -    return qatomic_read(&ram_block_discard_disabled) > 0;
> >> +    return qatomic_read(&ram_block_discard_disablers);
> >>  }
> > return value won't be bool?
>
> The compiler does type conversion.
>
> != 0 -> true
> == 0 -> false
ah... I missed it :(

Thanks,
Pankaj



reply via email to

[Prev in Thread] Current Thread [Next in Thread]