[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] sev: enable seret injection to a self described area in
From: |
no-reply |
Subject: |
Re: [PATCH 0/3] sev: enable seret injection to a self described area in OVMF |
Date: |
Wed, 9 Dec 2020 11:33:43 -0800 (PST) |
Patchew URL: 20201209172334.14100-1-jejb@linux.ibm.com/">https://patchew.org/QEMU/20201209172334.14100-1-jejb@linux.ibm.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20201209172334.14100-1-jejb@linux.ibm.com
Subject: [PATCH 0/3] sev: enable seret injection to a self described area in
OVMF
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/20201209172334.14100-1-jejb@linux.ibm.com ->
patchew/20201209172334.14100-1-jejb@linux.ibm.com
* [new tag] patchew/20201209173536.1437351-1-groug@kaod.org ->
patchew/20201209173536.1437351-1-groug@kaod.org
- [tag update] patchew/cover.1607467819.git.alistair.francis@wdc.com ->
patchew/cover.1607467819.git.alistair.francis@wdc.com
Switched to a new branch 'test'
f51e90d sev: update sev-inject-launch-secret to make gpa optional
4f524bc pc: add parser for OVMF reset block
915ed52 sev: add sev-inject-launch-secret
=== OUTPUT BEGIN ===
1/3 Checking commit 915ed52b80aa (sev: add sev-inject-launch-secret)
2/3 Checking commit 4f524bc2ee18 (pc: add parser for OVMF reset block)
ERROR: braces {} are necessary for all arms of this statement
#50: FILE: hw/i386/pc_sysfw.c:148:
+ if (ovmf_table)
[...]
ERROR: braces {} are necessary for all arms of this statement
#61: FILE: hw/i386/pc_sysfw.c:159:
+ if (!qemu_uuid_is_equal((QemuUUID *)ptr, &guid))
[...]
ERROR: braces {} are necessary for all arms of this statement
#68: FILE: hw/i386/pc_sysfw.c:166:
+ if (tot_len <= 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#90: FILE: hw/i386/pc_sysfw.c:188:
+ if (qemu_uuid_parse(entry, &entry_guid) < 0)
[...]
ERROR: braces {} are necessary for all arms of this statement
#93: FILE: hw/i386/pc_sysfw.c:191:
+ if (!ptr)
[...]
ERROR: braces {} are necessary for all arms of this statement
#112: FILE: hw/i386/pc_sysfw.c:210:
+ if (!len)
[...]
ERROR: braces {} are necessary for all arms of this statement
#118: FILE: hw/i386/pc_sysfw.c:216:
+ if (data)
[...]
ERROR: braces {} are necessary for all arms of this statement
#120: FILE: hw/i386/pc_sysfw.c:218:
+ if (data_len)
[...]
total: 8 errors, 0 warnings, 123 lines checked
Patch 2/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/3 Checking commit f51e90dbc914 (sev: update sev-inject-launch-secret to make
gpa optional)
WARNING: line over 80 characters
#67: FILE: target/i386/monitor.c:750:
+ error_setg(errp, "SEV: no secret area found in OVMF, gpa must be
specified.");
total: 0 errors, 1 warnings, 44 lines checked
Patch 3/3 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
20201209172334.14100-1-jejb@linux.ibm.com/testing.checkpatch/?type=message">http://patchew.org/logs/20201209172334.14100-1-jejb@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [PATCH 0/3] sev: enable seret injection to a self described area in OVMF, James Bottomley, 2020/12/09
Re: [PATCH 0/3] sev: enable seret injection to a self described area in OVMF,
no-reply <=