Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HE

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HE

From:	Richard Henderson
Subject:	Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros
Date:	Wed, 9 Dec 2020 09:56:58 -0600
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 12/8/20 4:56 PM, Alistair Francis wrote:
> The helper functions defined in helper.h specify that the argument is of
> type target_long. Let's change the implementation to match the header
> definition.

Given that these are riscv64 specific, you could alternately change the header
definition.  Dunno if that's clearer or not, considering an implementation like
float32_to_int64 -- is it immediately obvious whether or not we are truncating
the result?

r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 01/15] hw/riscv: Expand the is 32-bit check to support more CPUs, (continued)
- [PATCH v2 01/15] hw/riscv: Expand the is 32-bit check to support more CPUs, Alistair Francis, 2020/12/08
- [PATCH v2 02/15] target/riscv: Add a TYPE_RISCV_CPU_BASE CPU, Alistair Francis, 2020/12/08
- [PATCH v2 03/15] riscv: spike: Remove target macro conditionals, Alistair Francis, 2020/12/08
- [PATCH v2 04/15] riscv: virt: Remove target macro conditionals, Alistair Francis, 2020/12/08
- [PATCH v2 05/15] hw/riscv: boot: Remove compile time XLEN checks, Alistair Francis, 2020/12/08
  - Re: [PATCH v2 05/15] hw/riscv: boot: Remove compile time XLEN checks, Richard Henderson, 2020/12/09
    - Re: [PATCH v2 05/15] hw/riscv: boot: Remove compile time XLEN checks, Alistair Francis, 2020/12/09
- [PATCH v2 06/15] hw/riscv: virt: Remove compile time XLEN checks, Alistair Francis, 2020/12/08
- [PATCH v2 07/15] hw/riscv: spike: Remove compile time XLEN checks, Alistair Francis, 2020/12/08
- [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros, Alistair Francis, 2020/12/08
  - Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros, Richard Henderson <=
    - Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros, Alistair Francis, 2020/12/09
- [PATCH v2 08/15] hw/riscv: sifive_u: Remove compile time XLEN checks, Alistair Francis, 2020/12/08
- [PATCH v2 10/15] target/riscv: Add a riscv_cpu_is_32bit() helper function, Alistair Francis, 2020/12/08
  - Re: [PATCH v2 10/15] target/riscv: Add a riscv_cpu_is_32bit() helper function, Richard Henderson, 2020/12/09
    - Re: [PATCH v2 10/15] target/riscv: Add a riscv_cpu_is_32bit() helper function, Alistair Francis, 2020/12/09
- [PATCH v2 11/15] target/riscv: Specify the XLEN for CPUs, Alistair Francis, 2020/12/08
  - Re: [PATCH v2 11/15] target/riscv: Specify the XLEN for CPUs, Richard Henderson, 2020/12/09
    - Re: [PATCH v2 11/15] target/riscv: Specify the XLEN for CPUs, Alistair Francis, 2020/12/09
- [PATCH v2 12/15] target/riscv: cpu: Remove compile time XLEN checks, Alistair Francis, 2020/12/08
  - Re: [PATCH v2 12/15] target/riscv: cpu: Remove compile time XLEN checks, Richard Henderson, 2020/12/09

Prev by Date: Re: [PATCH v2 05/15] hw/riscv: boot: Remove compile time XLEN checks
Next by Date: Re: [RFC PATCH 00/27] vDPA software assisted live migration
Previous by thread: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros
Next by thread: Re: [PATCH v2 09/15] target/riscv: fpu_helper: Match function defs in HELPER macros
Index(es):
- Date
- Thread