[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v9 08/32] i386: move TCG accel files into tcg/
From: |
Claudio Fontana |
Subject: |
Re: [RFC v9 08/32] i386: move TCG accel files into tcg/ |
Date: |
Wed, 9 Dec 2020 12:05:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 12/9/20 10:30 AM, Alex Bennée wrote:
>
> Claudio Fontana <cfontana@suse.de> writes:
>
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> ---
>> target/i386/meson.build | 14 +-------------
>> target/i386/{ => tcg}/bpt_helper.c | 0
>> target/i386/{ => tcg}/cc_helper.c | 0
>> target/i386/{ => tcg}/excp_helper.c | 0
>> target/i386/{ => tcg}/fpu_helper.c | 0
>> target/i386/{ => tcg}/int_helper.c | 0
>> target/i386/{ => tcg}/mem_helper.c | 0
>> target/i386/tcg/meson.build | 13 +++++++++++++
>> target/i386/{ => tcg}/misc_helper.c | 0
>> target/i386/{ => tcg}/mpx_helper.c | 0
>> target/i386/{ => tcg}/seg_helper.c | 0
>> target/i386/{ => tcg}/smm_helper.c | 0
>> target/i386/{ => tcg}/svm_helper.c | 0
>> target/i386/{ => tcg}/tcg-stub.c | 0
>> target/i386/{ => tcg}/translate.c | 0
>> 15 files changed, 14 insertions(+), 13 deletions(-)
>> rename target/i386/{ => tcg}/bpt_helper.c (100%)
>> rename target/i386/{ => tcg}/cc_helper.c (100%)
>> rename target/i386/{ => tcg}/excp_helper.c (100%)
>> rename target/i386/{ => tcg}/fpu_helper.c (100%)
>> rename target/i386/{ => tcg}/int_helper.c (100%)
>> rename target/i386/{ => tcg}/mem_helper.c (100%)
>> create mode 100644 target/i386/tcg/meson.build
>> rename target/i386/{ => tcg}/misc_helper.c (100%)
>> rename target/i386/{ => tcg}/mpx_helper.c (100%)
>> rename target/i386/{ => tcg}/seg_helper.c (100%)
>> rename target/i386/{ => tcg}/smm_helper.c (100%)
>> rename target/i386/{ => tcg}/svm_helper.c (100%)
>> rename target/i386/{ => tcg}/tcg-stub.c (100%)
>> rename target/i386/{ => tcg}/translate.c (100%)
>
> I noticed target/i386/helper-tcg.h is still in the main directory. It
This is something to fix in
i386: move TCG cpu class initialization out of helper.c
will do, thanks!
> maybe be a straggler that is harder to separate - if so might be worth
> mentioning in the commit message. Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
- [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants, (continued)
- [RFC v9 01/32] accel/tcg: split CpusAccel into three TCG variants, Claudio Fontana, 2020/12/08
- [RFC v9 05/32] i386: move whpx accel files into whpx/, Claudio Fontana, 2020/12/08
- [RFC v9 06/32] i386: move hax accel files into hax/, Claudio Fontana, 2020/12/08
- [RFC v9 07/32] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs, Claudio Fontana, 2020/12/08
- [RFC v9 08/32] i386: move TCG accel files into tcg/, Claudio Fontana, 2020/12/08
- [RFC v9 09/32] i386: move cpu dump out of helper.c into cpu-dump.c, Claudio Fontana, 2020/12/08
- [RFC v9 11/32] tcg: cpu_exec_{enter,exit} helpers, Claudio Fontana, 2020/12/08
- [RFC v9 12/32] tcg: make CPUClass.cpu_exec_* optional, Claudio Fontana, 2020/12/08
- [RFC v9 10/32] i386: move TCG cpu class initialization out of helper.c, Claudio Fontana, 2020/12/08
- [RFC v9 13/32] tcg: Make CPUClass.debug_excp_handler optional, Claudio Fontana, 2020/12/08