[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h' |
|
Date: |
Tue, 8 Dec 2020 18:01:42 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 12/8/20 5:56 PM, Richard Henderson wrote:
> On 12/7/20 6:36 PM, Philippe Mathieu-Daudé wrote:
>> Make gen_msa() and gen_msa_branch() public declarations
>> so we can keep calling them once extracted from the big
>> translate.c in the next commit.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> target/mips/translate.h | 2 ++
>> target/mips/translate.c | 4 ++--
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Actually, I think this should be dropped, and two other patches rearranged.
r~
- [PATCH 06/17] target/mips: Alias MSA vector registers on FPU scalar registers, (continued)
- [PATCH 06/17] target/mips: Alias MSA vector registers on FPU scalar registers, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 07/17] target/mips: Extract msa_translate_init() from mips_tcg_init(), Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 08/17] target/mips: Remove CPUMIPSState* argument from gen_msa*() methods, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 09/17] target/mips: Explode gen_msa_branch() as gen_msa_BxZ_V/BxZ(), Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 10/17] target/mips: Rename msa_helper.c as mod-msa_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 11/17] target/mips: Move msa_reset() to mod-msa_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 12/17] target/mips: Extract MSA helpers from op_helper.c, Philippe Mathieu-Daudé, 2020/12/07
- [PATCH 14/17] target/mips: Declare gen_msa/_branch() in 'translate.h', Philippe Mathieu-Daudé, 2020/12/07
[PATCH 16/17] target/mips: Introduce decode tree bindings for MSA opcodes, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 13/17] target/mips: Extract MSA helper definitions, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 15/17] target/mips: Extract MSA translation routines, Philippe Mathieu-Daudé, 2020/12/07
[PATCH 17/17] target/mips: Use decode_msa32() generated from decodetree, Philippe Mathieu-Daudé, 2020/12/07